kengjit / pe

0 stars 0 forks source link

Did not follow convention for diagram #15

Open kengjit opened 3 years ago

kengjit commented 3 years ago

Please follow the standard convention as per CS2113T

image.png

image.png

nus-pe-script commented 2 years ago

Team's Response

What's not following the convention?

Items for the Tester to Verify

:question: Issue response

Team chose [response.IssueUnclear]

Reason for disagreement: As per the textbook, I am unsure what kind of UML diagram this is.

If it is an object diagram, it should be following this convention:

image.png

It should not be split into smaller segments (Constants, Constructors, Methods, etc)

The same goes for Enums

image.png