search

kenglxn / QRGen

a simple QRCode generation api for java built on top ZXING
http://glxn.net/2012/03/10/qrgen-a-small-wrapper-on-top-of-zxing-for-generating-qrcodes-in-java
1.49k stars 299 forks source link

Upgrading zxing to newest version #130

Closed wojciechUrbanski closed 5 years ago

wojciechUrbanski commented 5 years ago

zxing in version 3.3.0 contains vulnerability that can end up in Buffer Overflow: https://ossindex.sonatype.org/vuln/80d18c11-c2d5-481c-ae03-809b865aa715

zxing in version 3.4.0 seems to have upgraded imageio library and no longer exposes this vulnerability.

Upgrading zxing to 3.4.0 requires the upgrade of roboelectric to 3.0 version. Other way, there will be errors (reflection related) during running unit tests on android subproject. As consequence, the QRGenShadowBitmap was removed as it is redundant - same implementation is provided by ShadowBitmap.

This time double checked if project is compiling and tests are passing - everything seems to be fine locally

kenglxn commented 5 years ago

thank you. seems like travis builds no longer run on PRs 🤷‍♂️. I’ll merge this anyway, and se what happens on master.

kenglxn commented 5 years ago

the build actually did run and passed, it just isn’t visible on github for some reason.