search

kenglxn / QRGen

a simple QRCode generation api for java built on top ZXING
http://glxn.net/2012/03/10/qrgen-a-small-wrapper-on-top-of-zxing-for-generating-qrcodes-in-java
1.49k stars 299 forks source link

Preparing release of 2.7.0 #151

Closed Lonzak closed 1 year ago

Lonzak commented 1 year ago

Couldn't get the android stuff running since a lot of dependencies are missing. Except for that everything looks good...

kenglxn commented 1 year ago

nice! thanks @Lonzak I will look at this in the morning.

kenglxn commented 1 year ago

Small update: I started looking at the state of things this morning, and regardless of this PR the roboelectric stuff is just broken. I spent some time trying to fix it, but it's a mess to be honest. Looks like they broke maven support a while back.

Long story short. I should be able to merge your changes, I just have to get a passing build set up. Which also means I have to throw out robolectric.

Lonzak commented 1 year ago

Yes I had the same impression with the roboelectric stuff. Strange thing. Thanks for the update...

PS: Maybe this helps? https://github.com/robolectric/robolectric/issues/3344

kenglxn commented 1 year ago

Yes I had the same impression with the roboelectric stuff. Strange thing. Thanks for the update...

PS: Maybe this helps? robolectric/robolectric#3344

Thanks. I spent quite some time looking into it, and decided to give up. If someone wants to reintroduce robolectric after the build is fixed without it that could be an option. I just dont have the time to fix it now.

kenglxn commented 1 year ago
kenglxn commented 1 year ago

I will go ahead and merge this into a branch on my fork, and resolve the conflicts. It will be available as 3.0.0 since I had to bump to java 11

Lonzak commented 1 year ago

Ah really? So is the bytecode level also already java11? Damn we are still compiling with 8 ....

kenglxn commented 1 year ago

Yes, I believe so. This project has been and is pretty idle for a long time

kenglxn commented 1 year ago

I resolved the conflicts. Now I will merge this into my fork and create the 3.0.0 release.

kenglxn commented 1 year ago

Thanks for the contrib @Lonzak 🎉

Lonzak commented 1 year ago

Thanks you as well! Would it be possible to create a 2.7.0 compatible with Java8 (8 is better but 7 would also suffice)? Unfortunately version 3.0.0 is now not usable for me and every effort would be in vain :-/

kenglxn commented 1 year ago

I'll give it a shot

kenglxn commented 1 year ago

Can you try this https://jitpack.io/#kenglxn/qrgen/2.7.0 hopefully works

        <dependency>
        <groupId>com.github.kenglxn</groupId>
        <artifactId>qrgen</artifactId>
        <version>2.7.0</version>
    </dependency>
Lonzak commented 1 year ago

I am trying out right now...Will update when it is working... Update : After struggeling a bit with maven and the above mentioned repo I got it to work. So seems good! Thank you