search

kenglxn / QRGen

a simple QRCode generation api for java built on top ZXING
http://glxn.net/2012/03/10/qrgen-a-small-wrapper-on-top-of-zxing-for-generating-qrcodes-in-java
1.49k stars 299 forks source link

New qr code schema implementations #93

Closed pawlidim closed 6 years ago

pawlidim commented 6 years ago

Added more qr code schema implementation

kenglxn commented 6 years ago

fix for https://github.com/kenglxn/QRGen/issues/72

kenglxn commented 6 years ago

This is looking very good :) I wonder if you could check if you can get the diff down to just the relevant changes in QRcode.java in android and javase. After that I think this is good to merge.

kenglxn commented 6 years ago

Awesome 💪

Could you fix formatting on the other files as well, so all files are tab size 4 instead of 8?

kenglxn commented 6 years ago

Nevermind. I see that there is already a mix of codestyle. I will do a cleanup sometime in the future, so don’t worry about it.

I will try to get around to merging this PR later today. Thanks again for your contribution 🙂

pawlidim commented 6 years ago

I found a style guide project from google for Google-originated open-source projects. It looks very good. Thank you and best regards. Max https://github.com/google/styleguide

kenglxn commented 6 years ago

Thanks again. I will get 2.4.0 released very soon. Hopefully within the next couple of days. If not, then before new years eve.