search

kengz / SLM-Lab

Modular Deep Reinforcement Learning framework in PyTorch. Companion library of the book "Foundations of Deep Reinforcement Learning".
https://slm-lab.gitbook.io/slm-lab/
MIT License
1.26k stars 266 forks source link

Fixed docker image build error #325

Closed Rahim16 closed 5 years ago

Rahim16 commented 5 years ago

Docker fails to build the image because of the error in the last run statement which runs all the tests. The error is due to flaky using pytest internal apis, discussed more here: https://github.com/box/flaky/issues/139

In the newer version of flaky this issue is fixed and simply updating the dependence to a newer version in the environment.yml fixes the docker build.

kengz commented 5 years ago

Thanks for catching that @Rahim16 ! Also a quick note, a major update is coming with with the full-Atari benchmark, but it's still in a branch v4-dev. It is stable now, so feel free to use that, although it will be merged to master in a few days.