search

kenhyuwa / vue-tailwind-picker

:tada: Datepicker component for vue.js build with Tailwind CSS & dayjs date library
https://vue-tailwind-picker.netlify.app/
193 stars 38 forks source link

ask: dayjs is bundled #4

Closed mazipan closed 4 years ago

mazipan commented 4 years ago

You can see https://bundlephobia.com/result?p=vue-tailwind-picker@1.1.0, the dayjs is become part of your library. This means people might have different dayjs version in their project. For this case, dayjs should become peerDependencies, not dependencies. We let users install their own dayjs.

But this is just my opinion, you might have your own reasons for this decision.

kenhyuwa commented 4 years ago

Thank you for suggestion, I have moved dayjs & tailwindcss to peerDependencies