search

kenianbei / vcard_parser

Parses and validates vCard data according to RFC 6350 specification.
MIT License
6 stars 3 forks source link

Support optional serde feature. #5

Closed tmpfs closed 1 year ago

tmpfs commented 2 years ago

Adds support for serde to the Vcard type using the serde feature flag.

tmpfs commented 2 years ago

@kenianbei, thanks so much for landing the chrono/time change so quickly.

For some context about this, I need to pass the Vcard type via some webassembly bindings to Javascript and serde is the only reasonable way for me to achieve this right now as I don't want to add another vCard parser to the Javascript side.

kenianbei commented 2 years ago

No problem, I have also done that before with wasm... I will take take a look at this tomorrow morning.

kenianbei commented 2 years ago

We should hold off on this until https://github.com/kenianbei/vcard_parser/issues/8 is resolved.

tmpfs commented 1 year ago

Hey @kenianbei,

I need this for my program and I also needed a parser that is fully compliant with RFC6350; your implementation deviates in some places, in particular I noticed the date/time handling is not compliant.

So I rolled my own here:

https://docs.rs/vcard4/latest/vcard4/

I reckon it's about 95% compliant with RFC6350, it is well tested with very good coverage. I wonder what you think? Maybe you want to try it out for your TUI? Would be cool if we could collaborate to get it to be fully compliant with the RFC.

Thanks 🙏