search

kenichi / angelo

Sinatra-like DSL for Reel that supports WebSockets and SSE
Other
303 stars 23 forks source link

Params #34

Closed tommay closed 9 years ago

tommay commented 9 years ago

Yeah I sit around doing things like this instead of doing tests for the code I've written. But a method called "parse_post_body" that also parsed the query_string was asking for a bit of refactor so it would stop confusing me.

kenichi commented 9 years ago

seeing intermittent failure from the test @katjaeinsfeld added, but i think it is a ramification of the define_app business:

1) Failure: Angelo::Base::test Angelo::Base subclasses#test_0001_answers to up_and_running [/Users/ken/src/ruby/angelo/test/angelo_spec.rb:457]: --- expected +++ actual @@ -1 +1 @@ -"{\"error\":\"757: unexpected token at 'ok'\"}" +"ok"

i think i have a quick fix...

kenichi commented 9 years ago

yeah, sorry - not related. :+1:

tommay commented 9 years ago

Not related but yeah I've seen this failure. It's consistent for a given value of the test seed.

On Thu, Jan 22, 2015 at 10:35 AM, kenichi nakamura <notifications@github.com

wrote:

yeah, sorry - not related.

— Reply to this email directly or view it on GitHub https://github.com/kenichi/angelo/pull/34#issuecomment-71072796.