Closed mighe closed 9 years ago
ah, it looks like the new websocket-driver stuff does not expose the driver. since websocket-driver has its own ping, we should attempt to use that, eh?
whoa, the new stuff depends on rack and uses Rack::MockRequest?
I see this too, and it bothered me. It's coming over by websocket-driver
as you said. I've not wanted Rack
anywhere near Reel
or any DSL it supports. I will look into this also.
@digitalextremist do you think it could be useful to have a ping
method exposed by Reel?
At the moment the only way @kenichi has is to use directly a Reel dependency and this could lead to unexpected problems in the future (like this one).
If pinging a websocket is a useful feature for many developers, having it integrated in Reel is probably the best thing.
@mighe we can expose ping
( forwarding to ping
on @driver
) no problem.
my immediate fix was to add :driver to the attr_accessor list, but then i saw the mockrequest and went down a rabbit hole of trying to make reel work without that.
@digitalextremist :+1:
Yeah I am going to make it work without Rack
again. I swear there should be a C
in front of Rack
because every now and then someone keeps getting us hooked again. And it's all in good fun and everyone is having a rad party committing stuff, and then it's like :bomb: Rack
reappeared muahahaha
@digitalextremist @mighe see https://github.com/celluloid/reel/pull/188
If we clean this up and make sure it's solid, I'll cut a pre2
with this in, while we wait on UNIX
sockets.
much has been done as a result of this issue, thanks @mighe.
Hi @kenichi, I was trying angelo with reel 0.6.0.pre1 and I get the following error:
the problem is here: the code is using a class from the old websocket parser, that has been removed with the websocket-driver integration.