search

kenichi / angelo

Sinatra-like DSL for Reel that supports WebSockets and SSE
Other
303 stars 23 forks source link

now dumps backtraces to configured logger #66

Closed Mask closed 8 years ago

Mask commented 8 years ago

Is there any reason to explicitly dump backtraces to STDERR? If not, I suggest the following minor change. This will help if the user has configured a special logger (e.g. logging via network to graylog or logstash) the backtraces will now be sent to this logger instead of landing in STDERR.

Ruby loggers normally detect if passed an exception, and dump the backtrace automatically.

kenichi commented 8 years ago

@Mask sorry for the late response. i'm running into troubles with rake running the tests on ruby-2.3.1, for some reason. running them without rake on 2.3.1 actually has yields some errors in the angelo/main code where method_defined? no longer exists on main. none of this really affects your change, and so i'm just going to merge it. thanks for pointing this out and fixing it!