search

kenichi / angelo

Sinatra-like DSL for Reel that supports WebSockets and SSE
Other
303 stars 23 forks source link

Angelo doesn't work with Ruby 3 #83

Open tenyo opened 2 years ago

tenyo commented 2 years ago

Hello in 2022! We're still using Angelo for one of our projects and got an error when trying to switch to Ruby 3. The specific error seems to be related to the mustermann gem which is locked to an old version (0.4), but I guess there could be others. Any chance to update the angelo dependencies?

kenichi commented 2 years ago

Hi @tenyo - many of the upstream dependencies are no longer maintained, specifically the entire celluloid ecosystem: reel, celluloid:io, celluloid... which angelo depends on for base functionality. That said, I tried to fire up some of the examples on ruby 3.1 and found some basic things to update/fix. The tests still hang somewhere, but it gets them runnable. Hopefully, this may be a helpful jumping off point 🤞🏽

tenyo commented 2 years ago

Thanks so much @kenichi ! Looks like this might do the trick! Do you want me to do some testing with my project?

kenichi commented 2 years ago

I did some more testing, but haven't been able to nail down what is happening. Something fundamental in the websocket negotiation in Reel (upstream dep) is broken for me, even on older rubies. Feel free to continue trying with these changes, but I can't make any guarantees. I'll likely archive this repository very soon.