Open blagburn opened 5 years ago
Hi Blagburn, thanks for reaching out. I checked the following sample code on my end and got the offending points to turn blue.
stat_qc_violations(method = "XmR", violation_point.color = "blue")
Looking over your plots, I did see a single red dot in the 3 sigma violations plot. I also checked the rules in your other plots too see if there was anything else that was supposed to be marked.
Violation Same Side: 8 or more consecutive, same-side points - No violating points
Violation 1 Sigma: 4 or more consecutive, same-side points exceeding 1 sigma - No violating points
Violation 2 Sigma: 2 or more consecutive, same-side points exceeding 2 sigma - No violating points
Violation 3 Sigma: any points exceeding 3 sigma - One violating point
Please let me know if this was a different result than you were expecting.
Best regards,
KG
Ok, after reviewing the violation rules in a reference book. ggQC needs a revision to its violation detection. The only facets that are completely correct are the same side facet and the 3 sigma facet. The 1 and 2 sigma facets need revision:
For example, the rule being used for 1 sigma violation is 4 or more consecutive, same-side points exceeding 1 sigma. The actual rule is... "whenever at least 4/5 successive points fall on the the same side of the center-line and the points exceed 1 sigma. ..
Thanks for reporting the error.
Thank you for the clarification. I am enjoying the package a lot! Thanks!
Matt Blagburn
Please excuse any mistakes as this message is being sent from my smart phone.
On Fri, Dec 14, 2018, 8:43 AM kenithgrey <notifications@github.com wrote:
Ok, after reviewing the violation rules in a reference book. ggQC needs a revision to its violation detection. The only facets that are completely correct are the same side facet and the 3 sigma facet. The 1 and 2 sigma facets need revision:
For example, the rule being used for 1 sigma violation is 4 or more consecutive, same-side points exceeding 1 sigma. The actual rule is... "whenever at least 4/5 successive points fall on the the same side of the center-line and the points exceed 1 sigma. ..
Thanks for reporting the error.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kenithgrey/ggQC/issues/40#issuecomment-447329355, or mute the thread https://github.com/notifications/unsubscribe-auth/AZqOYhADFudw1OzU11mMjDFxfBKpe7i9ks5u46sYgaJpZM4ZSqzk .
Hello, Thank you in advance for your help! I am utilizing your package and I am having an issue with the point color for qc violations. I was hoping you would have an idea of what I am doing wrong.
m_base_count <- ggplot(diehard, aes(x =
Date Opened, y = n)) + stat_qc_violations(method = "XmR", violation_point.color = "Red") + ggtitle("All Violations") m_base_count
Please let me know if the picture does not work. I am very to Github.