search

kenjdavidson / react-native-bluetooth-classic

⚛ Bluetooth classic Android(Bluetooth)/IOS(ExternalAccessory) module for serial communication
https://kenjdavidson.github.io/react-native-bluetooth-classic
MIT License
250 stars 93 forks source link

New Arch Support #334

Open brianwachira opened 3 months ago

brianwachira commented 3 months ago

Mobile Device Environment Android & IOS

Is there a plan for supporting the new architecture? You can check out more information on enabling new arch here

Would you need help with this? I can spare sometime just to help out in the contribution of this.

kenjdavidson commented 3 months ago

I don't work for the company I did while creating this library, so I haven't done mobile development in a few years now. If someone would like to contribute I would definitely accept PRs, as I do continue to help out.

But I have zero plans at this point to do it myself. I don't have the time, nor the experience with react native at this point to realistically do it.

Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: brianwachira @.> Sent: Wednesday, July 31, 2024 6:00:07 AM To: kenjdavidson/react-native-bluetooth-classic @.> Cc: Subscribed @.***> Subject: [kenjdavidson/react-native-bluetooth-classic] New Arch Support (Issue #334)

Mobile Device Environment Android & IOS

Is there a plan for supporting the new architecture? You can check out more information on enabling new arch herehttps://github.com/reactwg/react-native-new-architecture

Would you need help with this? I can spare sometime just to help out in the contribution of this.

— Reply to this email directly, view it on GitHubhttps://github.com/kenjdavidson/react-native-bluetooth-classic/issues/334, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABPMJL3CJCMZ62PKO2SRZWLZPCYSPAVCNFSM6AAAAABLYDZ5CWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQZTSNRUGIYDGMI. You are receiving this because you are subscribed to this thread.Message ID: @.***>

brianwachira commented 3 months ago

I don't work for the company I did while creating this library, so I haven't done mobile development in a few years now. If someone would like to contribute I would definitely accept PRs, as I do continue to help out. But I have zero plans at this point to do it myself. I don't have the time, nor the experience with react native at this point to realistically do it. Get Outlook for Androidhttps://aka.ms/AAb9ysg … ____ From: brianwachira @.> Sent: Wednesday, July 31, 2024 6:00:07 AM To: kenjdavidson/react-native-bluetooth-classic @.> Cc: Subscribed @.> Subject: [kenjdavidson/react-native-bluetooth-classic] New Arch Support (Issue #334) Mobile Device Environment Android & IOS React Native relseaed a new architecturehttps://reactnative.dev/docs/the-new-architecture/ React Native team is planning to enable the New Architecture by default by the end of 2024https://reactnative.dev/docs/the-new-architecture/ Is there a plan for supporting the new architecture? You can check out more information on enabling new arch herehttps://github.com/reactwg/react-native-new-architecture Would you need help with this? I can spare sometime just to help out in the contribution of this. — Reply to this email directly, view it on GitHub<#334>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABPMJL3CJCMZ62PKO2SRZWLZPCYSPAVCNFSM6AAAAABLYDZ5CWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQZTSNRUGIYDGMI. You are receiving this because you are subscribed to this thread.Message ID: @.>

I see. I'd be interested to contribute but with guidance. If it's ok, could you pin this issue at the issues tab so that anyone else can see it and jump in to comment and contribute?

kenjdavidson commented 3 months ago

You're more than welcome to contribute, there are a couple things that are important for me to understand though, just based on the requirements.

The new architecture is:

ShaneZhengNZ commented 3 months ago

My 2 cents - if time is an issue, then, we should do the 1st step to make sure this lib is compatible with the interop layer, as described below: https://github.com/reactwg/react-native-new-architecture/blob/main/docs/enable-libraries.md

By doing so, the lib users can upgrade to the new RN version when the new architecture becomes the default.

Then we can work on the conversion to the turbo modules.

brianwachira commented 4 weeks ago

My 2 cents - if time is an issue, then, we should do the 1st step to make sure this lib is compatible with the interop layer, as described below: https://github.com/reactwg/react-native-new-architecture/blob/main/docs/enable-libraries.md

By doing so, the lib users can upgrade to the new RN version when the new architecture becomes the default.

Then we can work on the conversion to the turbo modules.

Ok, New Arch is enabled by default in the current React Native version 0.76 @ShaneZhengNZ could we start? if it is ok, kindly guide

kenjdavidson commented 4 weeks ago

If you're open to work through the changes, feel free to start testing, and open issues as they come up. I'll monitor and look at PRs as they come in.

I haven't done move dev in a while now, so I may not be the best resource, but I will guide where possible (design and implementation).

harshit-evit commented 5 days ago

any update

kenjdavidson commented 5 days ago

Not in my end. I'm looking for help with this. Someone with react native experience and time to do so. I'm more than willing to assist, review PRs and handle the deployments. But I'm still in the same boat, I done have time to do the development myself.

mojjominion commented 16 hours ago

Hi, I can try and add support for new architecture here at-least for android side of things. I am not aware of ios related stuff.

kenjdavidson commented 12 hours ago

It should be pretty straight forward, from what I remember we don't use any of the things that need to be changed (keys, spread, etc). SO it should just be testing against 0.74 and adding the new file/options:

https://gist.github.com/cipolleschi/82b7a9561b8861330efabbd3eb08c6f5