search

kenjis / ci-app-for-ci-phpunit-test

CodeIgniter Test Application for ci-phpunit-test
31 stars 20 forks source link

Changed the inheritor of `CIPHPUnitTestRequest` #18

Closed ytetsuro closed 6 years ago

ytetsuro commented 6 years ago

TestCase -> CIPHPUnitTestCase

@see: https://github.com/kenjis/ci-phpunit-test/pull/254

kenjis commented 6 years ago

Why this PR is a test for it?

ytetsuro commented 6 years ago

constructor in CIPHPUnitTestCase is depends TestCase. Because this PR code is should occur error.

kenjis commented 6 years ago

@ytetsuro This PR does not express the intent.

kenjis commented 6 years ago

I added the test for it: https://github.com/kenjis/ci-app-for-ci-phpunit-test/commit/194abe99550e1eb7735f579dc09860063afc0575

ytetsuro commented 6 years ago

This PR does not express the intent.

informative. Thank you very much.