Risky was occurred.

[rochefort]

I called show_404 in a controller, but risky was occurred. I should close object in show_404. Any good ideas?

message:

$ phpunit -v --debug controllers/Welcome_test.php
R

Time: 416 ms, Memory: 8.50Mb

There was 1 risky test:

1) Welcome_test::test_method_404
Test code or tested code did not (only) close its own output buffers

/Users/trsw/.composer/vendor/phpunit/phpunit/src/TextUI/Command.php:153
/Users/trsw/.composer/vendor/phpunit/phpunit/src/TextUI/Command.php:105

OK, but incomplete, skipped, or risky tests!
Tests: 1, Assertions: 2, Risky: 1.

Generating code coverage report in Clover XML format ... done

Generating code coverage report in HTML format ... done

application code:

# application/config/routes.php
$route['foo/(.*)'] = "welcome/index/$1";

# application/controllers/Welcome.php
    public function index()
    {
        $rsegment_array = $this->uri->rsegment_array();
        $method = $rsegment_array[3];
        if ($method == 'bar') {
            show_404();
        }

        $this->load->view('welcome_message');
    }

testing code:

    /**
     * @expectedException       PHPUnit_Framework_Exception
     * @expectedExceptionCode   404
     */
    public function test_method_404()
    {
        $this->request('GET', 'foo/bar');
    }

[kenjis]

How about this? https://github.com/kenjis/ci-phpunit-test/commit/7e256d9ba49ca77546ef73795d694c8d70f8043b

[rochefort]

You are great! I should have use ob_get_level like this. Thank you for your commit.

[kenjis]

Output buffering of PHP is stackable.

Thank you for your report!

[trungdq88]

@kenjis I am having a same problem here, but my code is not simple as show_404 but really complicated. Do you have any advice on how to trace down the output buffering issue?

My test target method is using form_validation, ReCaptcha (third-party library) and bunch of models.

[kenjis]

The reason PHPUnit reports risky is you have output buffer which is not cleared. $this->request() calls ob_start().

You have to search ob_start() and make sure all of them are cleared and buffering is turned off.

[trungdq88]

@kenjis thank you, I found the reason.

There are severals call to ob_start() in core/Exceptions.php. When there is PHP Error in the application, CI render the error template and somehow mess around with the output buffering. I fixed that by fixing the error in my application code, not sure if this is a CodeIgniter's issue or should we fix it in ci-phpunit-test.

Anyway, the risky test helped me to know if there is unexpected PHP Errors in the output, so I find it helpful in an unexpected way.