search

kenjis / codeigniter-ss-twig

A Simple and Secure Twig integration for CodeIgniter 3.x and 4.x
MIT License
168 stars 46 forks source link

HMVC Support #13

Closed daycry closed 8 years ago

daycry commented 8 years ago

This file is OK

kenjis commented 8 years ago

Why don't you just add paths for modules in config? Do you really need to the functionality which adds module path dynamically?

kenjis commented 8 years ago

You can set module path dynamically when loading this Twig library. See https://github.com/kenjis/codeigniter-ss-twig#loading-twig-library

I don't want to couple this libary with HMVC. Because it is a simple library.

daycry commented 8 years ago

I think that is better, because you dont need create any config file. On 8 Apr 2016 02:02, "kenjis" notifications@github.com wrote:

Why don't you just add paths for modules in config? Do you really need to the functionality which adds module path dynamically?

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/kenjis/codeigniter-ss-twig/pull/13#issuecomment-207143267

kenjis commented 8 years ago

@daycry I don't use HMVC as possible. Because it provides more complexity to CodeIgniter. The official CodeIgniter will never support HMVC. So I don't want to couple my Twig library tightly with HMVC.

At least, you need to write test code for your code. The current code coverage is 98.51%, but your PR has no test code, and the coverage is 81.61%.