search

kenjis / codeigniter-ss-twig

A Simple and Secure Twig integration for CodeIgniter 3.x and 4.x
MIT License
168 stars 46 forks source link

Compatible with newest version #25

Closed kimtree closed 7 years ago

kimtree commented 7 years ago

Hi,

Recently, I had a problem with using your codeigniter-ss-twig library on Twig v2.2. I know you didn't mention that this library supports Twig v2.x, but I simply checked and realize that I can use this library on Twig v2.x as well.

This PR simply changed deprecated option value in twig 1.21 to support later versions. http://twig.sensiolabs.org/doc/1.x/deprecated.html#miscellaneous

kenjis commented 7 years ago

@kimtree Thanks! Would you change the version in composer.json? See https://github.com/kenjis/codeigniter-ss-twig/blob/master/composer.json#L17

kimtree commented 7 years ago

@kenjis Hi, I've update composer.json matches to the dependency. But I think this library also works on Twig 2 which needs PHP 7+. How can we deal with this version dependency issue?

kenjis commented 7 years ago

@kimtree I've merged for now. I don't use Twig 2.x at all. So I don't add 2.x to composer.json now. After I check Twig 2.2, I will add 2.2 to composer.json.

kimtree commented 7 years ago

@kenjis I see, Thanks.