search

kenjyoung / MinAtar

GNU General Public License v3.0
283 stars 56 forks source link

`register_envs` overwrites names of original Atari Envs #21

Open shivakanthsujit opened 2 years ago

shivakanthsujit commented 2 years ago

In the register_envs function, the name given to the classes does not include "MinAtar/". Because of this, if you call register_envs, it will overwrite the names of the original ALE games. This also means that calling gym.make("MinAtar/Breakout-v0") or any other game doesn't work since there are no registered envs starting with "MinAtar". The bug is in

https://github.com/kenjyoung/MinAtar/blob/2a12fc8af0402f7473c567b2d74f7236b2551681/minatar/gym.py#L58-L70

It can be fixed by just modifying "id="{}-v0".format(name)," to "id="MinAtar/{}-v0".format(name)," for both v0 and v1.

I can open a PR for this if you like.

kenjyoung commented 2 years ago

I've used commands like gym.make("MinAtar/Breakout-v0") and they seem to work as intended for me.

Are you using a sufficiently recent version of gym that includes the plugin system? For example <pip install gym==0.21.0> as mentioned in the README?