search

kenjyoung / MinAtar

GNU General Public License v3.0
283 stars 56 forks source link

Gym compatible API #4

Closed calio closed 3 years ago

calio commented 5 years ago

It would be really nice to have a Gym compatible API so that existing code can be applied to MinAtar directly.

qlan3 commented 5 years ago

Please check this: https://github.com/qlan3/gym-games

jkterry1 commented 3 years ago

It seems like this Gym functionality should be upstreamed into this repo?

kenjyoung commented 3 years ago

I added the gym wrapper to the repo as an optional addition. Please let me know if there are any issues with it!

vonHartz commented 2 years ago

I added the gym wrapper to the repo as an optional addition. Please let me know if there are any issues with it!

I just installed MinAtar from Github (Python 3.6.13) and it looks like environments are not automatically registered. KeyError: 'MinAtar/Breakout-v1' Problem seems to be that the envs are just registered as eg. 'Breakout-v1', not 'MinAtar/Breakout-v1'` as they should.

kenjyoung commented 2 years ago

I've been using the current gym environment implementation lately and it seems to be working as intended for me.

Are you using a sufficiently recent version of gym? For example <pip install gym==0.21.0> as mentioned in the README? The issue you are describing sounds vaguely like what I experienced initially when I had an older version of gym installed.

vonHartz commented 2 years ago

Wow, thanks for the quick reply!

Sounds like that might be the reason. Dependency-hell forces me to stick with 0.19 for now, but simply re-registering the envs with a prefix worked.