Enable one-line installation via pip

kenjyoung / MinAtar

GNU General Public License v3.0

283 stars 56 forks source link

Enable one-line installation via pip #5

Closed edran closed 5 years ago

edran commented 5 years ago

This PR moves dependencies to setup.py (since you already needed that), enabling to install the package simply with python setup.py install.

This is useful if one wants to add minatar as a dependency to their packages, or simply do pip install git+ssh://git@github.com/kenjyoung/MinAtar@master#egg=minatar without the manual clone.

edran commented 5 years ago

@kenjyoung @TianTian1137 I've also restructured the package to enable develop mode with pip. I don't think I've broken anything, but please have a look.

kenjyoung commented 5 years ago

Thanks for the PR! This does look like a nicer way to structure the package.

I changed setup.py to use setuptools instead of distutil. I also made some changes to the installation instructions.

Please verify that everything still looks ok to you and I should be able to accept.

edran commented 5 years ago

LGTM.