Fixed incorrect behaviour in some games when difficulty ramping was disabled. Default behaviour should not be effected.

kenjyoung / MinAtar

GNU General Public License v3.0

283 stars 56 forks source link

Fixed incorrect behaviour in some games when difficulty ramping was disabled. Default behaviour should not be effected. #7

Closed ercumentilhan closed 4 years ago

ercumentilhan commented 4 years ago

Are these conditions meant to work the way I changed them into?

kenjyoung commented 4 years ago

Yes, the alien positioning should be handled correctly by operator precedence (but doesn't hurt to be explicit), but the ramping condition indeed seems incorrect. The same issue also exists in seaquest, could you fix that as well and then I should be able to accept the request.

Thanks for noticing this!

ercumentilhan commented 4 years ago

Thanks for reviewing! Done.

ondrejbiza commented 4 years ago

What's the severity of this bug? I disabled difficulty ramping for some of my experiments, so I'm wondering if they're completely invalid.

kenjyoung commented 4 years ago

The games affected are seaquest and asterix. For those games, it looks like the ramping switch was effectively ignored. So the behaviour with ramping disabled will be equivalent to default in those cases. Sorry for the oversight.

ondrejbiza commented 4 years ago

No worries, thanks for the answer!