kenmoini / ocp4-ai-svc-universal

Ansible automated multi-platform deployment of OpenShift 4 via the Assisted Installer Service
MIT License
5 stars 12 forks source link

Update ldap-group-sync.yml #4

Closed msolberg closed 1 year ago

msolberg commented 1 year ago

We ran into a situation where the config map wasn't being created because we were using type=='ActiveDirectory'. Removing the conditional, since this whole section is conditional on provider.type.

kenmoini commented 1 year ago

Did the generated ActiveDirectory config work? I think I had the conditional in there cause I hadn't tested the ActiveDirectory config.

msolberg commented 1 year ago

Yep. Everything else worked fine. I think we changed out one of the mappings, but that was a preference, not a requirement.

Michael.

On Mon, Jan 30, 2023 at 10:23 AM Ken Moini @.***> wrote:

Did the generated ActiveDirectory config work? I think I had the conditional in there cause I hadn't tested the ActiveDirectory config.

— Reply to this email directly, view it on GitHub https://github.com/kenmoini/ocp4-ai-svc-universal/pull/4#issuecomment-1408819509, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATNNGFMW7JWAOJQ3Q66MQ3WU7MGFANCNFSM6AAAAAAULI3L7E . You are receiving this because you authored the thread.Message ID: @.***>

-- Michael Solberg Chief Field Architect, Red Hat, Inc.

kenmoini commented 1 year ago

Sounds good, thank ya kindly!