Fix: Handle linebreaks added to the executed command by the Telnet cl…

kennedyshead / aioasuswrt

MIT License

24 stars 24 forks source link

Fix: Handle linebreaks added to the executed command by the Telnet cl… #52

Closed JJdeVries closed 3 years ago

JJdeVries commented 3 years ago

…ient

kennedyshead commented 3 years ago

I would love a unit-test for this, trying to get all the tests for connections up and running again ;)

kennedyshead commented 3 years ago

Nice one! How do you feel about a unit-test?

JJdeVries commented 3 years ago

Pfoe, so finally the tests are successful. For me this merge now seems done, the writer/reader mocks should enable a more robust checking of the TelnetConnection, although I think the most relevant parts are now captured.