search

kennedyshead / aioasuswrt

MIT License
25 stars 24 forks source link

Allow arp to process uppercase MAC Addresses. #6

Closed halkeye closed 6 years ago

halkeye commented 6 years ago

My router is returning:

? (192.168.1.142) at 00:18:DD:04:E2:FA [ether] on br0

Added a bunch of tests to confirm letters are working properly. I tried to base it on my own router, but its in ap mode, so I can't check what the leases file looks like

halkeye commented 6 years ago

(all the other PRs were in prep for this one, so it should get quiet again after this)

maweki commented 6 years ago

You're allowed to use trailing commas in python lists. If this is done consistently, adding to a list is just one insertion in git instead of two insertions and one removal

kennedyshead commented 6 years ago

@maweki You are welcome with PR ;)

halkeye commented 6 years ago

You're allowed to use trailing commas in python lists. If this is done consistently, adding to a list is just one insertion in git instead of two insertions and one removal

oh interesting. Good call. My personal style is to do not do that, because it broke in old javascript for ie11, but thats something I should start doing in python and javascript as it helps longer term.

kennedyshead commented 6 years ago

https://github.com/home-assistant/home-assistant/pull/18042