search

kennetek / gridfinity-rebuilt-openscad

A ground-up rebuild of the stock gridfinity bins in OpenSCAD
Other
1.14k stars 164 forks source link

fix #126 #137

Closed ch3vr0n5 closed 6 months ago

ch3vr0n5 commented 8 months ago

Added a thin cutout of the grid pattern with fillets at the walls and merged it just above the floor to add another layer between grid feet and reinforce the rounded corners at the walls. This should address #126

rcarmo commented 6 months ago

Can this be merged in?

Ruudjhuu commented 6 months ago

The issue I have with this pull request (and similar) is that I have no idea what happens in the gridfinity lite code, I have never had the need to look at it. Also due to absence of tests (and absence of testability in openscad) the risk of breaking something is in my opinion too big with only my review. This code base also has many side effects in its modules which makes te code unreadable. These reasons is why I started a similar project with build123d.

I am willing to merge this request if you are confident of the change and @kennetek does not react within an "acceptable" period of time (it has already been 2 months, so let's say a week?). Otherwise this codebase is not going forward, maybe we are at the point to take risks so it moves forward.