search

kennetek / gridfinity-rebuilt-openscad

A ground-up rebuild of the stock gridfinity bins in OpenSCAD
Other
1.14k stars 164 forks source link

add cylindrical cutouts to *_bins.scad #138

Closed jannessm closed 6 months ago

jannessm commented 8 months ago

I added cylindrical cutouts which are placed in a linear pattern to easily support more advanced bins.

Ruudjhuu commented 8 months ago

This is a nice idea.

Could you put most of the logic in a new module in the utility file? Then the function you adapted is still very simple. Add two booleans to enable the "normal" cutouts and the cylindrical cutouts and make some logic to pick the correct cutout module. Also add some error handling, (if both booleans are enabled report a message to the user that this is probably not what they want).