search

kennetek / gridfinity-rebuilt-openscad

A ground-up rebuild of the stock gridfinity bins in OpenSCAD
Other
1.13k stars 164 forks source link

Make style_hole=4 compatible with only_corners #158

Closed jpypi closed 4 months ago

jpypi commented 5 months ago

Make gridfinity refined magnet holes compatible with the only_corners option.

Ruudjhuu commented 4 months ago

Please add some before and after screenshots.

jpypi commented 4 months ago

Before: before Basically while style_hole=4 when only_corners=true it's falling back to `style_hole=2``.

After: after

I realize that this doesn't quite match what gridfinity refined looks like when it's on all corners. That is, normally there is one slot on each edge, where as with only_corners on the slots are only on two opposite edges. I was mostly just trying to get this working quickly since not having it at all was a blocker for the project I was working on (web-based parametric bin generator). If it makes more sense I'm happy to try to re-work it and get the slots-on-edges to match more closely to gridfinity refined style, though to some extent, I suppose having holes only on the corners is a deviation from that to begin with, so it's not clear to me how important that is.

Ruudjhuu commented 4 months ago

It would be nice to keep rotation in mind if other not round holes are added on the future. However, this works and adds value to the project.

I think I saw your project the last day on reddit, looks great!