kennetek / gridfinity-rebuilt-openscad

A ground-up rebuild of the stock gridfinity bins in OpenSCAD
Other
1.13k stars 164 forks source link

Add chamfers to cylindrical cutout holes #161

Closed tstranex closed 4 months ago

tstranex commented 5 months ago

Here's how it looks in preview mode:

preview

Here's how it looks in render mode:

render
w33ble commented 4 months ago

FYI, it would help to add this to the arguments passed to cutCylinders so that it works out of the box. Without that, changing that parameter doesn't do anything.

This is a nice addition though 👍🏾

diff --git a/gridfinity-rebuilt-bins.scad b/gridfinity-rebuilt-bins.scad
index ff1d930..ea176a9 100644
--- a/gridfinity-rebuilt-bins.scad
+++ b/gridfinity-rebuilt-bins.scad
@@ -95,7 +95,7 @@ gridfinityInit(gridx, gridy, height(gridz, gridz_define, style_lip, enable_zsnap

     } else if (cdivx > 0 && cdivy > 0) {

-        cutCylinders(n_divx=cdivx, n_divy=cdivy, cylinder_diameter=cd, cylinder_height=ch, coutout_depth=c_depth, orientation=c_orientation);
+        cutCylinders(n_divx=cdivx, n_divy=cdivy, cylinder_diameter=cd, cylinder_height=ch, coutout_depth=c_depth, orientation=c_orientation, chamfer=c_chamfer);
     }
 }
 gridfinityBase(gridx, gridy, l_grid, div_base_x, div_base_y, style_hole, only_corners=only_corners);
image
tstranex commented 4 months ago

@w33ble Ah, good catch, thanks! I've updated the code in the pull request.