kennetek / gridfinity-rebuilt-openscad

A ground-up rebuild of the stock gridfinity bins in OpenSCAD
Other
1.13k stars 164 forks source link

Radii and dimensions are not correct! #165

Closed Bobbel93 closed 2 months ago

Bobbel93 commented 4 months ago

Please check the exact dimensions again.

https://gridfinity.xyz/specification/

IMG_6002

IMG_6003

plaes commented 4 months ago

I can confirm that there is something incorrect, but I can't say what exactly: https://github.com/kennetek/gridfinity-rebuilt-openscad/blob/2f2567d7a9f1672aa4d6d5cfe998cdb76db81b61/standard.scad#L12-L17

Firstly, descriptions for r_fo1, r_fo2 and r_fo3 are wrong, these are actually diameters (but they are correctly divided by two in the code). Comparing these values to gridfinity standard, then r_fo1 should be changed to 7.5.

And another suspicious variable seems to be r_c2:

// upper base chamfer "radius"
r_c2 = 1.4;  // should be 2.15 / 2 ?

Update: I assume one of the reason for using somewhat different values is the usage of "rounded" chamfer instead of proper 45-degree one.

plaes commented 4 months ago

@Bobbel93 Please check #167

EmperorArthur commented 4 months ago

Depending on how PR #171 goes, I will try using the same method to handle the edges of the bin. That is:

I have a suspicion that one of the reasons for your issues is the way hull() works. The math for the base is reversed, and can be hard to read. I started cleaning it up, but realized that just sweeping a path would give a better result that could be easily verified as matching the profile.

EmperorArthur commented 3 months ago

Looks like half of #169 was actually a duplicate of this one. I've moved that and the relevant screenshots here.

Screenshots of issue in Freecad

Commit 2f2567d

2024-02-18 gridfinity-rebuilt-bins 1x1x6 (solid) FreeCAD - Commit 2f2567d 2024-02-18 gridfinity-rebuilt-bins 1x1x6 (solid) FreeCAD Zoomed In - Commit 2f2567d

Commit 5df8267

2024-02-18 gridfinity-rebuilt-bins 1x1x6 (solid) FreeCAD Zoomed In Back - Commit 5df8267 2024-02-18 gridfinity-rebuilt-bins 1x1x6 (solid) FreeCAD Front - Commit 5df8267 2024-02-18 gridfinity-rebuilt-bins 1x1x6 (solid) FreeCAD Zoomed In Front - Commit 5df8267

EmperorArthur commented 3 months ago

@plaes and @Bobbel93 please check #171

I've re-created the profile based on the spec. Which lead me to adjust r_base to equal r_fo1.

I have not checked if this works on the old code, but it fixes the issue in that PR.

2024-01-25 Fixed Bin Radius