kennetek / gridfinity-rebuilt-openscad

A ground-up rebuild of the stock gridfinity bins in OpenSCAD
Other
1.13k stars 164 forks source link

fix(utility): make internal auto height lower #166

Closed w33ble closed 4 months ago

w33ble commented 4 months ago

This PR lowers the automatic height of the internal block. I printed a bin with a divider down the middle, intending to stack other bins on top of it. However, I found that the divider is a little too tall and the bins on the top don't sit cleanly in the lip, they rest and pivot on the divider instead.

Another way to achieve this might be to introduce an automatic height offset variable instead of relying on a fixed value. That way you could still use the automatic setting but still adjust the max height. I'm open to other ideas too.

I still need to make a test print to confirm the new value is correct, but the renders look right at least.

Before:

SCR-20240209-iykf

After:

SCR-20240209-iyci
w33ble commented 4 months ago

Here's a couple test prints to illustrate the issue. I added a straight line so you can see how the divider on the first print bows because it's being pushed up by the bin. In the after photo, you can see there's a gap and the two surfaces aren't touching.

The spacing might be too much, and I'm open to doing this another way, but I think this proves that the default height offset isn't quite big enough.

Before: IMG_7792

After: IMG_7793

Ruudjhuu commented 4 months ago

If I check with the original bins created by Zack, your before is as supposed to be.

The bottom of the bin should rest on the flat surface of the bin below. The stacking lips have a clearance so the top bin fits "in" the bottom bin without force.

Or your printer is tuned perfectly and the (I think) 0.25 mm clearance on each side is too much for you. Or your printer print a little bit smaller than instructed.

I do not intend to merge this as we want to comply with Zacks original design.

I value the effort. If you think I'm wrong say so.

w33ble commented 4 months ago

I do not intend to merge this as we want to comply with Zacks original design.

Fair enough, I'll close this then. I didn't realize the bins were supposed to rest on that lip, the end result is kind of annoying when you divide the bin in weird ways because they kind of protrude.

At the very least, it would be nice to add a configuration so users could adjust this, but I fully understand not wanting to break from the spec as a default.