search

kennetek / gridfinity-rebuilt-openscad

A ground-up rebuild of the stock gridfinity bins in OpenSCAD
Other
1.13k stars 164 forks source link

RFC: Attempt to fix radius defines #167

Closed plaes closed 4 months ago

plaes commented 4 months ago

This is a first set of code smells I found due to #165. Pull request is split into 3 commits, one for each variable.

image

gshpychka commented 4 months ago

Should have taken this opportunity to fix the incorrect comments (these are diameters, not radii)

plaes commented 4 months ago

Should have taken this opportunity to fix the incorrect comments (these are diameters, not radii)

@gshpychka Code was updated to use these values as radii.

gshpychka commented 4 months ago

Should have taken this opportunity to fix the incorrect comments (these are diameters, not radii)

@gshpychka Code was updated to use these values as radii

Oh, my bad, didn't realize that