Open EmperorArthur opened 2 months ago
I have an update to the printable option that uses the affine matrices, and I've found works better in Cura. Just completed yesterday, but I was debating how I wanted to back-port it. I will post a comment and convert this from draft status when those are done.
Ready for review/merge.
Since the last review I have done the following:
Cura likes to print in mid-air if "top/bottom pattern" is set to "Concentric!" So the multiple printable layers help with droop and mitigate that bug.
The test cases only run on Windows, but that's purely a hard-coded path issue. Once this is merged I will work on a PR for the CI/CD system, and add test case to prevent #180 from happening again.
This completely re-works how holes for bins are created. Adding multiple options that can be mixed and matched.
Re-worked Features
The code for how these are generated has changed, but the output is the same.
refined_holes()
.gridfinityBase(...)
.New Features
That last one is admittedly pretty crazy, but there was no reason to prevent it. The only restriction is magnet holes don't work with refined holes, since they both do the same thing.
@Ruudjhuu This contains the pictures you were asking for in PR #144, but is incompatible with that PR.
There are additional pictures in the "images/base_hole_options/" folder.