search

kennetek / gridfinity-rebuilt-openscad

A ground-up rebuild of the stock gridfinity bins in OpenSCAD
Other
1.13k stars 164 forks source link

Fix Baseplate Not Rendering & Generate Baseplate From Profile #187

Open EmperorArthur opened 1 month ago

EmperorArthur commented 1 month ago

Incorporates #179

Main Changes

First, this fixes the baseplate not correctly in OpenSCAD version 2024.02.16 (git 55be9cf86). Done by switching from minovsky to offset in one function.

Second, instead of using a negative of the bin's this creates the base plate using technical data from the spec.

Other changes

Deprecated rounded_rectangle in favor of a new rounded_square function. Which operates like the built in square and cube functions.

Opinion

The minovsky function just seems to cause more issues than it is worth.

EmperorArthur commented 1 month ago

Pictures from python -m unittest

Edit: How do I make these smaller?!?

Also tests are not comprehensive, and do not cover other modes. The gaps are a rendering issue and are not there when creating the final model.

only_counterbored_screw_holes_top only_countersunk_screw_holes_bottom only_countersunk_screw_holes_top plain_magnet_holes_top ribbed_magnet_holes chamfered_and_ribbed_magnet_holes chamfered_magnet_holes magnet_and_counterbored_screw_holes_bottom magnet_and_counterbored_screw_holes_top magnet_and_countersunk_screw_holes_bottom magnet_and_countersunk_screw_holes_top magnet_holes_bottom no_holes_bottom no_holes_top only_counterbored_screw_holes_bottom

nirvdrum commented 1 month ago

I tried out this PR for my first Gridfinity baseplate. It worked great. I quite like the crush ribs for keeping magnets in place. Thanks for pulling this together.

EmperorArthur commented 2 weeks ago

Fit to drawer functionality has been lost.

The PR uses more modular construction (square_baseplate_lip, solid_square_baseplate, square_baseplate_corner), which appears to focus more on the modular and customizable aspect rather than ensuring the "fit to drawer" functionality.

Fit to drawer functionality has been restored, though tests were not added.

Please re-examine.

EmperorArthur commented 1 week ago

Works as intended. Excellent updates.

Thanks! Whenever you're ready feel free to merge it, as I don't have permissions to do so.