search

kennetek / gridfinity-rebuilt-openscad

A ground-up rebuild of the stock gridfinity bins in OpenSCAD
Other
1.13k stars 164 forks source link

allow decimals for some values in the customizer #189

Open Rocka84 opened 1 month ago

Rocka84 commented 1 month ago

This adds some comments to allow entering decimal places for some values in the customizer.

EmperorArthur commented 1 month ago

Awesome! Would you mind adding a comment at the top of the file or somewhere explaining why these are needed? I don't remember seeing anything about this functionality in the OpenSCAD customizer documentation.

Rocka84 commented 1 month ago

I don't remember seeing anything about this functionality in the OpenSCAD customizer documentation.

If found the information here.

Would you mind adding a comment at the top of the file or somewhere explaining why these are needed?

If this is standard OpenSCAD syntax, do we really need to explain it in the source?

djsigmann commented 20 hours ago

I think that the distancex and distancey options ingridfinity-rebuilt-baseplate.scad should also accept decimals, as I often find myself adding them manually in the code when trying to fit a baseplate to a drawer (preferably to a .01 precision).