search

kennetek / gridfinity-rebuilt-openscad

A ground-up rebuild of the stock gridfinity bins in OpenSCAD
Other
1.15k stars 166 forks source link

Feature/screw together minimal #48

Closed Ruudjhuu closed 1 year ago

Ruudjhuu commented 1 year ago

I love the idea of the screw together feature. However I do not use the "normal" screw holes and base magnets. I am probably not the only one so I created this.

I see I messed up my commits, The first commit should onlly be a refactor step (renaming, replacing code), but I see I included the POC of module profile_skeleton_minimal(). Well, the changes are minimal. Let me know what you think.

image

kennetek commented 1 year ago

I like the idea. Why did you refactor the names of the rounded block modules?

Ruudjhuu commented 1 year ago

well, the module rounded_square implies it will create something that reassembles a square with round corners, which is a 2d object. But the module creates a 3d object which is called a cube.

I was in need of a module which would create a rounded square (the 2d one), but that name was already taken by a function which more or less creates a rounded cube. So it felt right to refactor those names.

If you disagree, or I am just very wrong. I'll cherry pick in my repo and create a new PR.