kennetek / gridfinity-rebuilt-openscad

A ground-up rebuild of the stock gridfinity bins in OpenSCAD
Other
1.27k stars 187 forks source link

Feature/maximize height inside bin #52

Closed Ruudjhuu closed 1 year ago

Ruudjhuu commented 1 year ago

This would solve #42.

I don't know if you had another way in mind, if so you can consider this a POC. However, I liked the idea and now it is usable for me.

I do think this function is in need of a refactor step. There are too many code branches in this function alone and I am sure I did not test all of them manually.

kennetek commented 1 year ago

After reviewing your code, and trying my hand at it myself, I realized why that thickness is there. It is so that the gap between bases has enough material to be stable. By trying to minimize it, I was going to create basically a single layer of filament bridged between the bases, which would be really flimsy. So sorry for leading you down the wrong path, but it seems like an impractical feature. It would require each compartment to be "smart" and extend down only if it does not bridge between bases, which then would only give like 1.5 mm of height.

The issue with your implementation was that it did not mess with the bases - to fix the problem, the cutters have to slice into the base block a bit. You can see the corners are messed up image

Here is what I was thinking of, which then made me realize that compartments were getting really close to the pinch point between bases.

Current: image

Attempted "fix": image

Ruudjhuu commented 1 year ago

Ah, I see. I did overlook this issue.