search

kennetek / gridfinity-rebuilt-openscad

A ground-up rebuild of the stock gridfinity bins in OpenSCAD
Other
1.15k stars 166 forks source link

fix holes only on corners #89

Closed Ruudjhuu closed 1 year ago

Ruudjhuu commented 1 year ago

Fixes #88

spuder commented 1 year ago

Thank you for fixing this. I was wondering why the holes were working a few commits ago, but suddenly seemed to stop working.

spuder commented 1 year ago

While this change does fix an issue where no holes were being rendered, It seems the 'only corners' feature still isn't working. Tested on commit 1b9f71b4b541eb1676a17e6be94d365dd7aacb38

Screen Shot 2023-03-21 at 8 31 43 PM

Confirmed this feature was working on cd6f680

Ruudjhuu commented 1 year ago

Thanks for pointing out that this is not yet working for you.

Could you provide some more information about how to reproduce? I am not able to mimic your outcome.

The steps I took:

  1. git clone https://github.com/Ruudjhuu/gridfinity-rebuilt-openscad.git
  2. checkout hotfix/holes_at_corners
  3. change in gridfinity-rebuilt-bins.scad -> gridx = 4 gridy = 1
  4. openscad gridfnity-rebuiltj-bins.scad
  5. In the UI, check only corners
  6. repeat step 3-6 for gridx = 1 gridy = 4

image

spuder commented 1 year ago

There must have been something wrong with my test. Please disregard my previous comment.

Update

Confirmed that this is working as expected.

mastersta commented 1 year ago

Tested and working, thanks for fixing it.