search

kenneth-gray / react-aria-accordion

React accordion component that follows WAI-ARIA practices
MIT License
12 stars 2 forks source link

fix(Header): Spread toggle props before adding disabled prop when using getButtonToggleProps #3

Closed kenneth-gray closed 6 years ago

kenneth-gray commented 6 years ago

It was possible to set the disabled prop on the \

and then pass a different disabled prop to getButtonToggleProps() leading to an inconsistency. Now disabled can only be applied if it's set on the \
.

Checklist

  • [x] Documentation N/A
  • [x] Tests
  • [x] Ready to be merged
  • [x] Added myself to contributors table N/A
kenneth-gray commented 6 years ago

:tada: This PR is included in version 1.0.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: