search

kennethcachia / background-check

Automatically switch to a darker or a lighter version of an element depending on the brightness of images behind it.
http://kennethcachia.com/background-check/
MIT License
3.27k stars 282 forks source link

Canvas support #21

Closed jonnyscholes closed 10 years ago

jonnyscholes commented 10 years ago

Support for canvas would be awesome. Might work on a pull request over the weekend if i get time.

jonnyscholes commented 10 years ago

Was this already supported and I'm doing something wrong? Or do you think it doesn't suit the project?

kennethcachia commented 10 years ago

Hi!

I closed this one as I was cleaning up open issues, but you're more than welcome to submit a PR!

Is this related to https://github.com/kennethcachia/Background-Check/issues/13? I'm still not sure if this functionality should be part of BackgroundCheck, but I might revisit the idea.

jonnyscholes commented 10 years ago

For sure. The project in question should get some attention this weekend so I'll see what I can do. Looks like it should be fairly simple to slip in :) On 27/03/2014 11:51 PM, "Kenneth" notifications@github.com wrote:

Hi!

I closed this one as I was cleaning up open issues, but you're more than welcome to submit a PR!

Is this related to #13https://github.com/kennethcachia/Background-Check/issues/13? I'm still not sure if this functionality should be part of BackgroundCheck, but I might revisit the idea.

Reply to this email directly or view it on GitHubhttps://github.com/kennethcachia/Background-Check/issues/21#issuecomment-38798377 .

kennethcachia commented 10 years ago

Awesome! :)