search

kennethcachia / background-check

Automatically switch to a darker or a lighter version of an element depending on the brightness of images behind it.
http://kennethcachia.com/background-check/
MIT License
3.27k stars 282 forks source link

Remove window event listeners when plugin is destroyed #46

Open danielkorte opened 9 years ago

danielkorte commented 9 years ago

Currently, once the plugin is destroyed it keeps throwing errors in the get function since 'windowEvents' is no longer in the attrs variable. Removing the window listeners when the destroy function is called fixes that. Great plugin! Cheers!

LOK-Soft commented 8 years ago

+1 for merging this

LOK-Soft commented 8 years ago

is included in pull request #70 with additional fixes

Maximilianos commented 8 years ago

+1