Checking background on an image that is not visible in the window

kennethcachia / background-check

Automatically switch to a darker or a lighter version of an element depending on the brightness of images behind it.

http://kennethcachia.com/background-check/

MIT License

3.27k stars 282 forks source link

Checking background on an image that is not visible in the window #47

Open holgersindbaek opened 9 years ago

holgersindbaek commented 9 years ago

Hi guys

Awesome plugin you have here. I'm using it to check the background image of a slider I have and I change the color of the overlaying caption in relation to the image.

I'm having a weird issue though. When I scroll down (scroll past the slider), then background check has a problem checking the actual background the slider image. Seems like it's checking the background of whatever is visible in the image and not in the slideshow. Any guess on what this could all be about?

valikron commented 9 years ago

ghost commented 9 years ago

kennethcachia commented 9 years ago

The image visibility check needs some improvement and your issue is probably related to https://github.com/kennethcachia/background-check/issues/31

For the time being, you can try and process just the currently active image and the plugin will ignore the rest of the images within the slider. Makes sense?