search

kennethjiang / OctoPrint-Anywhere

MIT License
64 stars 18 forks source link

Email sends photo upside down #74

Closed kjgouldstone closed 5 years ago

kjgouldstone commented 5 years ago

I have rotated the Camera feed using settings however when the photo is sent in the print completion email it is still upside down. The email seems to ignore the settings.

kennethjiang commented 5 years ago

@kjgouldstone You are right that the email failed to consider cam orientation settings. Will fix it! Thank you for reporting this issue.

kjgouldstone commented 5 years ago

Great Thanks

kennethjiang commented 5 years ago

@kjgouldstone just pushed a version to fix it. Let me know if it works for you.

kjgouldstone commented 5 years ago

Hi,

I can confirm that the top to bottom flip has worked fine in the fix.

However the left to right flip does not seem to have worked.

See the clock showing 81 rather than 18.

Cheers [image: unnamed (5).jpg] Kim

On Wed, 23 Jan 2019 at 04:33, Kenneth Jiang notifications@github.com wrote:

@kjgouldstone https://github.com/kjgouldstone just pushed a version to fix it. Let me know if it works for you.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kennethjiang/OctoPrint-Anywhere/issues/74#issuecomment-456666920, or mute the thread https://github.com/notifications/unsubscribe-auth/AKjjShrvQmFxealVxkDcFrRqPE-yMM7fks5vF-YSgaJpZM4aMewS .

kennethjiang commented 5 years ago

Ok I will look into it

kennethjiang commented 5 years ago

What's your printer's orientation settings in OA?

I tested on my printer with only "Flip horizontally" and none of the other options checked. The image in the email came out correctly. I guess you probably also have "rotate 90/90cw" checked? Please let me know so that i can reproduce the problem.

kjgouldstone commented 5 years ago

Hi,

yes I have flip vertically and flip horizontally ticked

Kim

On Fri, 25 Jan 2019 at 16:22, Kenneth Jiang notifications@github.com wrote:

What's your printer's orientation settings in OA?

I tested on my printer with only "Flip horizontally" and none of the other options checked. The image in the email came out correctly. I guess you probably also have "rotate 90/90cw" checked? Please let me know so that i can reproduce the problem.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kennethjiang/OctoPrint-Anywhere/issues/74#issuecomment-457628651, or mute the thread https://github.com/notifications/unsubscribe-auth/AKjjSgXs7Q0AHXGXvrRY23iiax5tp7q5ks5vGy9KgaJpZM4aMewS .

kennethjiang commented 5 years ago

Got it fixed. No need to upgrade the plugin. Your next print should have the correct orientation in email. Thank you for reporting this bug @kjgouldstone

kjgouldstone commented 5 years ago

Great all working now.

Thanks for the support

Kim

On Fri, 25 Jan 2019 at 21:08, Kenneth Jiang notifications@github.com wrote:

Got it fixed. No need to upgrade the plugin in. Your next print should have the correct orientation in email. Thank you for reporting this bug @kjgouldstone https://github.com/kjgouldstone

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kennethjiang/OctoPrint-Anywhere/issues/74#issuecomment-457728981, or mute the thread https://github.com/notifications/unsubscribe-auth/AKjjShE1rxzA3c1MS33wW7IfaP7tdhBnks5vG3JfgaJpZM4aMewS .