search

kennethjiang / js-file-download

MIT License
918 stars 119 forks source link

Fix for Firefox #3

Closed jnishiyama closed 8 years ago

jnishiyama commented 8 years ago

Resolves issue #2

localjo commented 8 years ago

Probably just needs a rebase on master @jnishiyama :)

jnishiyama commented 8 years ago

target _blank is back in, didn't even realize I removed it, my apologies!

tymochko commented 8 years ago

Thanks for this fix. Although, Master branch on github is updated but for some reason it doesn't update on my machine. I had it installed previously and wanted to update changes, so I tried npm install react-file-download --save again or npm update and it didn't work.

As a workaround I succeeded by npm install https://github.com/kennethjiang/react-file-download/tarball/master

localjo commented 8 years ago

@tymochko You can use https://www.npmjs.com/package/npm-check-updates to update your dependencies, or to do it manually remove react-file-download from your package.json, run rm -rf node_modules/react-file-download, then npm install react-file-download --save. This applies any time you need to update a dependency, not just to react-file-download.

localjo commented 8 years ago

npm install react-file-download@0.3.1 --save should also work.

tymochko commented 8 years ago

@josiahsprague, sorry, non of these did not work for me.

Besides I tried rm -rf node_modules/react-file-download - and it was not right, I had to write npm rm -rf node_modules/react-file-download

kennethjiang commented 8 years ago

This fix is not in 0.3.1. Just published 0.3.2. please upgrade.