Updated type definitions don't appear to have been published

kennethjiang / js-file-download

MIT License

915 stars 119 forks source link

Updated type definitions don't appear to have been published #46

Closed danielearwicker closed 5 years ago

danielearwicker commented 5 years ago

The type definitions in this repo support Blob parameter as well as string. But the latest published version does not include this change.

kennethjiang commented 5 years ago

The type definition was added by @Domino987 as a PR. I'm not familiar with how it works. If you can submit a PR for this i'll be happy to merge it. @danielearwicker

hassankhan commented 5 years ago

@kennethjiang if you publish a new version of the package on NPM, the types will also be updated 😉

kennethjiang commented 5 years ago

Just published a new version. Can you check if the type definition is available now? @hassankhan

Bear with me for all these basic mistakes and questions since I have not caught up on type definition in JS.

hassankhan commented 5 years ago

Had a quick look and it all looks good to me 👍

kennethjiang commented 5 years ago

Awesome. Closing this issue.