kennethk-1201 / pe

0 stars 0 forks source link

`p list` does not list in alphabetical order #2

Open kennethk-1201 opened 1 year ago

kennethk-1201 commented 1 year ago

The UG stated that p list will list in patient records in alphabetical order

Screenshot 2023-04-14 at 2.33.04 PM.png

However, when invoking the command, the records are not in alphabetical order.

Screenshot 2023-04-14 at 2.32.16 PM.png

This is an issue as many people may use alphabetical order in the case they cannot remember the exact name. p find only partially addresses this. For example, let's say you have a patient called Johnathan and you can only remember the first part of his name was John. p find John will not output the patient with name Johnathan. Hence, users will naturally rely on the alphabetical feature of listing the patients. However, if this does not function then users may waste significant time finding the patient if 'Johnathan' is at the end of the list.

nus-se-bot commented 1 year ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

No details provided by team.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: No reason given by team for downgrading severity for some reason.

As stated originally, users will naturally rely on the alphabetical feature of listing the patients. I do not believe that this appears only in very rare situations and causes a minor inconvenience only. In only a single day, it is no surprise to see at least 50 (just my estimate) visiting a clinic. With 50 people per day, it will definitely be quite an inconvenience not having the list alphabetically sorted inside the application. The database will undoubtedly be quite large, without alphabetical sorting, it will not just be a very rare situation nor a minor inconvenience. It's analogous to the difference between a brute force search O(n) and a far more efficient binary search O(logn) solution.

And as stated previously, "p find only partially addresses this. For example, let's say you have a patient called Johnathan and you can only remember the first part of his name was John. p find John will not output the patient with name Johnathan." This case is not uncommon, especially for people with longer names (which is also common).

Hence, failing to have an alphabetical sort, causes occasional inconvenience to some users but they can continue to use the product. (Medium definition)