search

kennethk-1201 / pe

0 stars 0 forks source link

Drug Storage being automatically set to 0 and 499 for `d update` #8

Open kennethk-1201 opened 1 year ago

kennethk-1201 commented 1 year ago

In the UG for the d update command:

Screenshot 2023-04-14 at 3.02.29 PM.png

If drug storage is set below 0 or above 499, an error will not be triggered and the value will be set to the boundary.

I believe this is an issue that contradicts this:

Screenshot 2023-04-14 at 3.03.43 PM.png

If the purpose of this application is for drug inventory management, in the end that drug storage goes below 0 or above 499. The system should inform of this error. In the case that the user trusts the system and sees that drug storage is at 0, this may cause problems for the clinic as they think they have sufficient drugs but they actually don't.

This essentially results in the system giving misinformation to the user, which is quite dangerous for a clinics as they treat patients.

soc-pe-bot commented 1 year ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

You mentioned that "in the end that drug storage goes below 0 or above 499". Logically speaking, there can be no negative amount of drugs, what does it mean by "have sufficient drugs but they actually don't"?

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Essentially, the problem is misinformation given to the user. For example, let's say the clinic has 463 drugs. Then, there is a recent supply of 39 drugs. If you update the system with the d update command and increment by 39 accordingly, the number of drugs in the system will be recorded to be 499, when in reality it is 463 + 39 =

  1. This results in misinformation for the user, especially considering the fact that no error will be reported if this situation occurs.

Outcome: The user thinks that the clinic has 499 drugs, when in reality they have 502. Thus, this results in misinformation, going against the purpose of this application as a drug inventory management tool. Perhaps it would be better to prevent the command from occurring and reporting an error, rather than let the system "auto-correct" the mistake, which results in misinformation given to the user.