Fixes to make JSLint happy

kennethkufluk / js-mindmap

JavaScript Mindmap

http://kenneth.kufluk.com/google/js-mindmap/

MIT License

606 stars 146 forks source link

Fixes to make JSLint happy #6

Closed drewish closed 13 years ago

drewish commented 13 years ago

Make JSLint happy by:

Declaring variables once, in one statement at the beginning of each function.
Consistently indenting and using whitespace between operators.
Wrapping if and else blocks in curly braces.
Using === for comparisons.
Using "[]" rather than "new Array()" to initialize arrays.
Avoid using "static", which is a reserved word, as variable name.
Providing a radix to parseInt().

kennethkufluk commented 13 years ago

Don't know how the whitespace got so bad. Good fix.

Not overly fussed about making JSLint happy - don't agree with all those rules. But if it's done, it's done.

drewish commented 13 years ago

Yeah I think some of his stuff is a bit silly (continue and ++/--) but many really do help avoid problems.

kennethkufluk commented 13 years ago

Oh, yes, most of them are obvious and invaluable. Some of them are frivolous and silly. Would rather have the first, but ignore the second (a la JSHint), but the standard is JSLint. Thanks for doing the work. :)