search

kennethkufluk / js-mindmap

JavaScript Mindmap
http://kenneth.kufluk.com/google/js-mindmap/
MIT License
606 stars 146 forks source link

Performance #8

Closed drewish closed 13 years ago

drewish commented 13 years ago

couple of tweaks to improve performance. caching the jquery object isn't a huge win but it helps. i think deferring math might be a bigger win. i can setup some benchmarks on jsperf if you'd like some comparisons.

drewish commented 13 years ago

Humm... actually now I'm wondering if $(this.el) is even necessary. Other lines in there are just calling $this.el like it's already a jQuery object. I'll go test that out.

drewish commented 13 years ago

Okay verified that this.el is a jQuery object and reworked that commit to avoid repeatedly calling jQuery on it.