kennethlynne / ndcvideos.com

The official NDC conference video archive front-end
www.ndcvideos.com
30 stars 7 forks source link

Handle vimeo video playback #4

Closed kennethlynne closed 10 years ago

kennethlynne commented 10 years ago

Implement a component that takes a vimeo video id as a parameter, and renders a video component that takes up its containing elements.

Example:

<vimeo-video-component id="<ID>" />

arealmaas commented 10 years ago

Maybe try to use this directive: http://ngmodules.org/modules/ng-videosharing-embed. An easy way to fix it for now.

kennethlynne commented 10 years ago

Yes, it is a clean and nice approach for video. We can create a similar way of including pdfs and other files later on

arealmaas commented 10 years ago

Another alternative: http://toddmotto.com/creating-an-angularjs-directive-from-one-of-your-existing-plugins-scripts/

kennethlynne commented 10 years ago

Idd! Just implement your preferred one. I would say bower install ng-videosharing-embed is simplest, but the latter is the most customizable one.

kennethlynne commented 10 years ago

Actually. The ng-videosharing-embed is the one that is easiest to replace also. That makes it a very strong contender if you ask me! We probably want to integrate with the vimeo and youtube playback APIs down the road, then we might consider doing something more custom

arealmaas commented 10 years ago

Did something in between.. Doing some refactoring now, and it should be done soon

arealmaas commented 10 years ago

current syntax:

<media-player-component media="<video/media-object>"></media-player-component>

Need some extra logic in the component to make it truly generic for all types of content.. But as it is now, i think it is very customizable

arealmaas commented 10 years ago

Suggesting renaming the component to video-component. No use for a component that takes all types of content.. ˆ_ˆ

kennethlynne commented 10 years ago

yeeeah. video component is specific and nice. Media is to generic.