kennethnym / StarlightLauncher

A search-focused Android launcher
GNU General Public License v3.0
100 stars 7 forks source link

initial fastlane structures #34

Closed IzzySoft closed 2 years ago

IzzySoft commented 2 years ago

For your RFP at F-Droid. Be wecome to us my Fastlane Cheat Sheet to build on it, and my formatting hints for full_description.txt as well.

Besides, your app will show up here in my repo with the next sync at around 6 pm UTC, where it will stay until it gets listed at F-Droid.org itself (or even beyond that if you let me know you want it to stay); some background can be found here.

IzzySoft commented 2 years ago

For the Fastlane structures: mainly merging this PR :smile: It would be great if you'd add per-release changelogs as well, but that's optional and "icing on the cake" (though great for users as they'd see what changed before pressing the "update" button). I'd then adjust the YAML in my repo to check for Fastlane changes whenever pulling an update – and you're of course welcome to link to your app's presence in my repo from your Readme here (if you need a badge for that, I can offer you some).

As for inclusion with F-Droid.org, a definite answer is not yet possible. Once Fastlane is available we can proceed with your RFP: there, too, the corresponding YAML must be defined and added to our repo via a merge request. As the YAML there then also includes the build recipe, some issues might come up with the build where we might need your assistance with. Or it might just be a "piece of cake" (with or without the "icing" :grin:) and go through like a breeze, who knows?

To answer the yet-unasked question: inclusion process with F-Droid.org can take a little – 2..3 weeks are considered to be fast, so you'll need some patience. If you'd open the mentioned merge request yourself that could speed up the process, and I'll gladly assist you with that the same way I did with the Fastlane structures here: providing a ready-to-use YAML which should get you started.

kennethnym commented 2 years ago

if you'd add per-release changelogs as well

The changelog is indeed available (CHANGELOG.md)

there, too, the corresponding YAML must be defined and added to our repo via a merge request

Is it the same YAML that I filled in when I opened the RFP?

inclusion process with F-Droid.org can take a little – 2..3 weeks are considered to be fast, so you'll need some patience

I am not in a hurry to publish this to F-Droid, so that's not a problem for me at all!

I will go ahead and merge this PR to begin the Fastlane integration. Thank you so much for being so helpful!

IzzySoft commented 2 years ago

The changelog is indeed available (CHANGELOG.md)

That's a global changelog, and a link to that can of course be added to the app's links. What I meant was fastlane/metadata/android/en-US/changelogs/<versionCode>.txt with what changed with exactly this update. The content of that then would be displayed directly below the app description.

Is it the same YAML that I filled in when I opened the RFP?

Basically yes – would need some cleanup plus complementation. I can take a look at it and see what can be done there.

I am not in a hurry to publish this to F-Droid, so that's not a problem for me at all!

That's very good! So all that can happen then is either being proven right (it takes a while), or being positively surprised (ugh, already?) :rofl:

I will go ahead and merge this PR to begin the Fastlane integration. Thank you so much for being so helpful!

Thanks – and gladly!

IzzySoft commented 2 years ago

Oops, just noticed there's a trailing < in full_description.txt after "fuzzy search". Doesn't hurt, but you might wish to remove that one day :wink:

kennethnym commented 2 years ago

What I meant was fastlane/metadata/android/en-US/changelogs/.txt

I can definitely add that!

Oops, just noticed there's a trailing < in full_description.txt after "fuzzy search". Doesn't hurt, but you might wish to remove that one day 😉

I also didn't notice that until you mentioned it haha. Will clean it up in the future.

Please let me know if you have any build issue with the Fastlane build - I will be more than happy to help with that.

IzzySoft commented 2 years ago

I can definitely add that!

That'd be great, thanks!

I also didn't notice that until you mentioned it haha. Will clean it up in the future.

Yeah, nothing crucial – take your time :rofl:

Please let me know if you have any build issue with the Fastlane build - I will be more than happy to help with that.

I've triggered the bot at GitLab for a rerun, looks good! Also added the cleaned-up and amended YAML and marked the RFP ready for packaging. If you wish you can try your luck with the resulting YAML – no guarantees, but I'd say chances are good.